citrus simulator UI #177
Merged
citrus simulator UI #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbortt
added
IN PROGRESS
Type: Feature
TO REVIEW
Prio: High
State: To discuss
bbortt
commented
Oct 4, 2023
simulator-ui/src/main/webapp/content/images/citrus-simulator-transparent.png
Outdated
Show resolved
Hide resolved
bbortt
commented
Oct 4, 2023
simulator-ui/src/main/java/org/citrusframework/simulator/ui/filter/CookieCsrfFilter.java
Outdated
Show resolved
Hide resolved
bbortt
commented
Oct 4, 2023
simulator-ui/src/main/java/org/citrusframework/simulator/ui/filter/SpaWebFilter.java
Show resolved
Hide resolved
bbortt
force-pushed
the
feature/citrus-simulator-ui
branch
from
5160659 to
bd72f9b
Compare
bbortt
force-pushed
the
feature/citrus-simulator-ui
branch
4 times, most recently
from
66a1b18 to
230ed92
Compare
|
it is with great pleasure that I can give this PR into review @christophd. I know it's big and it's probably too much to look at it all! that's why I can give you the following hints and encourage you to try it locally, then "just merge it and see how it goes".
I will follow up with more right after the merge, but want to stop here first. otherwise this PR gets way to big (or even bigger 😉). |
turns out it does not. also the name
|
bbortt
force-pushed
the
feature/citrus-simulator-ui
branch
2 times, most recently
from
178900d to
7f841d0
Compare
bbortt
removed
IN PROGRESS
State: To discuss
Closed
This was referenced Oct 12, 2023
Merged
added new entity `org.citrusframework.simulator.model.TestResult` with one-to-many mapping to `org.citrusframework.simulator.model.TestParameter`. the entity shall later replace the current in-memory implementation of `org.citrusframework.report.TestReports` which is used in `org.citrusframework.simulator.listener.SimulatorStatusListener`.
updated the `org.citrusframework.simulator.listener.SimulatorStatusListener` in such a way that it uses the previously introduced `org.citrusframework.simulator.model.TestResult` entity to persist test results into the database.
* `toString` methods that do not end up in stackoverflows * more error prune entities that control their own lifecycle * transform persistent enums to backward compatible ordinal values
start building the new `simulator-ui` based on a minimal jhipster application.
displaying test results on the landing page mimics the behaviour of the old ui.
bbortt
force-pushed
the
feature/citrus-simulator-ui
branch
from
7f841d0 to
0203d01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a preview of the new simulator UI. it is not final yet, the following entities and the corresponding REST API cleanup are still missing:
these changes should however go much faster, since the ground-work has been done.
next, and probably most importantly, the landing page does not life up to its predecessor:
however, I did want to open this pull-request nonetheless, so you guys can see in which direction the change is heading. it's a combination of existing pull-requests (in merge-order): #171, #173.
and I think I must still add the copyright header to each of these files. can you please confirm this, @christophd?
closes #165.